liqiang
b119135836
Build latest book artifacts / build (push) Canceled after 0s
dependency resolution / resolve (3.11) (push) Canceled after 0s
dependency resolution / resolve (3.13) (push) Canceled after 0s
deploy-pages / build (push) Canceled after 0s
deploy-pages / deploy (push) Canceled after 0s
i18n consistency check / check (push) Canceled after 0s
provider adoption tests / test (chapter2/context-compression) (push) Canceled after 0s
provider adoption tests / test (chapter2/prompt-injection) (push) Canceled after 0s
provider adoption tests / test (chapter2/system-hint) (push) Canceled after 0s
provider adoption tests / test (chapter3/log-sanitization) (push) Canceled after 0s
web-search-agent tests / test (push) Canceled after 0s
web-search-agent tests / agentbook (push) Canceled after 0s
23 lines
1.2 KiB
Markdown
23 lines
1.2 KiB
Markdown
# Second independent review of the autonomous candidate
|
|
|
|
A fresh independent reviewer rejected the revised candidate. The XML parsing
|
|
and focused tests now pass, but the claimed persistence scope is inconsistent:
|
|
|
|
- `batch_runner.py` writes ShareGPT-format trajectory entries directly around
|
|
its JSONL persistence path instead of using `agent.trajectory.save_trajectory()`;
|
|
- the `save_sample` path in `run_agent.py` also writes trajectory entries
|
|
directly;
|
|
- neither path currently includes the new `evaluation` object.
|
|
|
|
Inspect the actual code rather than relying on these line references. Make the
|
|
metadata contract consistent across real trajectory persistence paths, ideally
|
|
through one shared entry builder/writer when that can be done without changing
|
|
existing filenames, schemas, return behavior, or error handling. Add focused
|
|
tests for the batch and sample paths or their shared production helper. Preserve
|
|
all existing fields and conversation bytes.
|
|
|
|
Run the new tests, relevant existing batch/trajectory tests, compilation, and
|
|
`git diff --check`. Update `BOOK_SELF_EVOLUTION_REPORT.md` with this review round
|
|
and exact results. Keep the same claim boundary, do not commit or push, and do
|
|
not edit the book repository.
|